Geek asks and answers

InvalidOperationException The connection was not closed. The status of the current connection is open

Why does this code raise an invalid operation exception?

private SqlCommand cmd; // initialized in the class constructor

public void End(string spSendEventNotificationEmail) {
  try {
    cmd.CommandText = spSendEventNotificationEmail;
    cmd.Parameters.Clear();
    cmd.Parameters.Add("@packetID", SqlDbType.Int).Value = _packetID;
    cmd.Parameters.Add("@statusID", SqlDbType.Int).Value = _statusID;
    cmd.Parameters.Add("@website", SqlDbType.NVarChar, 100).Value = Tools.NextStep;
    cmd.Connection.Open();
    cmd.ExecuteNonQuery();
  } finally {
    cmd.Connection.Close();
    cmd.Parameters.Clear();
    cmd.Dispose();
  }
  endCall = true;
}

InvalidOperationException

+5
source share
2 answers

You try to open a connection that is already open, this throws an exception.

Solution 1 (recommended):

Inspect your code, check all the parts where the connection was opened cmd.Connectionand make sure that it is always properly closed.

Solution 2 (quick'n'dirty fix):

before the line

cmd.Connection.Open();

add the following verification / cleaning code:

if (cmd.Connection.State == ConnectionState.Open)
{
    cmd.Connection.Close();
}
+7
source

Sql * , , . , .

, -

private readonly _connectionString = "...";

public void End(string spSendEventNotificationEmail) {
  using(var conn = new SqlConnection(_connectionString))
  using(var cmd = conn.CreateCommand())
  {
    cmd.CommandText = spSendEventNotificationEmail;
    cmd.Parameters.Add("@packetID", SqlDbType.Int).Value = _packetID;
    cmd.Parameters.Add("@statusID", SqlDbType.Int).Value = _statusID;
    cmd.Parameters.Add("@website", SqlDbType.NVarChar, 100).Value = Tools.NextStep;
    conn.Open();
    cmd.ExecuteNonQuery();
  }
  endCall = true;
}
+3

More articles:


All Articles