My code for swapping through Twitter friends using recursion does not work - iOS

I am trying to scroll through a user of Twitter friends using cursors. Since you get 20 at a time along with the next cursor, I thought recursion is the best way to handle this. However, I believe that because I use locks on the completion handler, it does not work correctly. I continue to receive only two pages of friends (40), and he returns.

- (void)fetchTwitterFriendsForCrush:(Crush*)crush
                         fromCursor:(NSString*)cursor
          usingManagedObjectContext:(NSManagedObjectContext*)moc
                         withSender:(id) sender
             usingCompletionHandler:(void(^)())completionHandler
{
    // twitter returns "0" when there are no more pages to receive
    if (([cursor isEqualToString:@"0"]) || (cursor == nil)) {
        completionHandler();
        return;
    }
    NSString *urlString =
    [NSString stringWithFormat:@"https://api.twitter.com/1.1/friends/list.json?cursor%@skip_status=1", cursor];
    NSURL *requestURL = [NSURL URLWithString:urlString];
    SLRequest *request = [SLRequest requestForServiceType:SLServiceTypeTwitter
                                            requestMethod:SLRequestMethodGET
                                                      URL:requestURL
                                               parameters:nil];
    request.account = self.twitterAccount;
    [request performRequestWithHandler:
     ^(NSData *responseData, NSHTTPURLResponse *urlResponse, NSError *error) {
        if (error) {
            NSLog(@"Error getting twitter friends = %@", error);
        }
        if (responseData) {
            NSError *jsonError;
            NSString *nextCursor = nil;
            NSMutableArray *friendsArray = [NSMutableArray arrayWithCapacity:100];
            NSDictionary *friendsDictionary =
            [NSJSONSerialization JSONObjectWithData:responseData
                                            options:0
                                              error:&jsonError];
            if ([friendsDictionary valueForKey:@"next_cursor_str"]) {
                nextCursor = [friendsDictionary valueForKey:@"next_cursor_str"];
            }
            if ([friendsDictionary valueForKey:@"users"]) {
                [friendsArray addObjectsFromArray:[friendsDictionary valueForKey:@"users"]];
            }
            for (NSDictionary *singleFriend in friendsArray) {
                NSString *twitterID = [singleFriend valueForKey:@"id_str"];
                NSString *name = [singleFriend valueForKey:@"name"];
                NSString *screenName = [singleFriend valueForKey:@"screen_name"];
                dispatch_queue_t mainQueue = dispatch_get_main_queue();

                dispatch_async(mainQueue, ^(void) {
                    // update model
                    TwitterFriend *newTwitterFriend =
                    [TwitterFriend twitterFriendWithTwitterID:twitterID
                                                     forCrush:crush
                                    usingManagedObjectContext:moc];
                    newTwitterFriend.name = name;
                    newTwitterFriend.screenName = screenName;
                });
            }
            [self fetchTwitterFriendsForCrush:crush
                                   fromCursor:nextCursor
                    usingManagedObjectContext:moc
                                   withSender:self
                       usingCompletionHandler:nil];
        }
    }];
}

And the method that calls it:

[self.twitterNetwork fetchTwitterFriendsForCrush:self.crush fromCursor:@"-1" usingManagedObjectContext:self.managedObjectContext withSender:self usingCompletionHandler:^{
    //
    [self reloadData];
}];

UPDATE: It seems that I get the same next_cursor data for every request. Has anyone experienced this? Or do you see anything in this code that might cause this?

+5
source share
1 answer
0

All Articles