Calling a method in another action from an action

Question

Calling a method in another action from an action

I know that we cannot call a method from an Activity that is in another action. I am trying to find a better way around this.

Here is my code. This is the method I'm trying to call. He is in my activity ScoreCard.

public void numPlayerSetup(){
{
    int[] ids = {
        R.id.TextView11, R.id.TextView12, R.id.TextView13
    };

    for(int i : ids) {
        TextView tv = (TextView)findViewById(i);
        tv.setVisibility(View.INVISIBLE);
    }

}

This is how I try to call the method. scoreis an object of a class ScoreCard.

public void onItemSelected(AdapterView<?> arg0, View arg1, int arg2, long arg3){
    int item = spinner.getSelectedItemPosition();


    if(item==1){
        Log.i("error","This Sucks");
        score.numPlayerSetup();
    }
}

I tried to put the method numPlayerSetupin another class that would not extend Activity, it would just contain logic, but I can not use the method findViewById()without the extension of activity.

This is what I call him.

public void onItemSelected(AdapterView<?> arg0, View arg1, int arg2, long arg3){
    int item = spinner.getSelectedItemPosition();
    ArrayList<TextView> myTextViewList = new ArrayList<TextView>();

    TextView tv1 = (TextView)findViewById(R.id.TextView14);
    myTextViewList.add(tv1);

    if(item==1){
        Log.i("error","This Sucks");
        Setup.numPlayerSetup(myTextViewList);
    }

Then this is the class I'm calling.

public class Setup {
    TextView tv;

    public static void numPlayerSetup(ArrayList<TextView> tvs){
        for(TextView tv : tvs) {
            Log.i("crash","This Sucks");
            tv.setVisibility(View.INVISIBLE);  //this line is highlighted in the debugger as the line my error is coming from
        }    
    }
}

It logs the message in logcat and gives me a null pointer exception. The debugger says that the value for tv is null. So I get a null pointer exception?

+3

android android-activity

user631063 14 . '11 3:38

3

ninjasense · Answer 1 · 2011-03-14T03:49:38+0000

Utitlity ( Activity) Textviews, . , .

public class Setup {

public static void numPlayerSetup(ArrayList<TextView> tvs){

                 for(TextView tv : tvs) {
                            tv.setVisibility(View.INVISIBLE);
                        }    
             }
}

( ):

ArrayList<TextView> myTextViewList = new ArrayList<TextView>();
TextView tv1 = (TextView)findViewById(R.id.tv1);
myTextViewList.add(tv1);


    Setup.numPlayerSetup(myTextViewList);

d45ks72a · Answer 2 · 2011-03-14T05:47:47+0000

, Activity

public class ScoreCard extends Activity{ 
 // ...   
public void numPlayerSetup(){  
        {  
             int[] ids = {  
                        R.id.TextView11, R.id.TextView12, R.id.TextView13
                    };

                    for(int i : ids) {
                        TextView tv = (TextView)findViewById(i);
                        tv.setVisibility(View.INVISIBLE);
                    }

                 }
             }
}

, Activity , ScoreCard

public class AnotherActivity extends ScoreCard{  
  // ...  

public void onItemSelected(AdapterView<?> arg0, View arg1, int arg2, long arg3){
        int item = spinner.getSelectedItemPosition();


        if(item==1){
            Log.i("success","This Rocks");
            numPlayerSetup();

    }
    }

}

, .

Rajeev kashyap · Answer 3 · 2013-08-26T08:46:32+0000

call activity from another action

main.xml

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent" >

<TextView
    android:id="@+id/textView14"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignParentLeft="true"
    android:layout_alignParentTop="true"
    android:layout_marginTop="14dp"
    android:text="Textview 4"
    android:textAppearance="?android:attr/textAppearanceLarge" />

<TextView
    android:id="@+id/textView11"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignParentLeft="true"
    android:layout_centerVertical="true"
    android:text="Textview 1"
    android:textAppearance="?android:attr/textAppearanceLarge" />

<TextView
    android:id="@+id/textView12"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_above="@+id/textView11"
    android:layout_alignParentLeft="true"
    android:layout_marginBottom="53dp"
    android:text="Textview 2"
    android:textAppearance="?android:attr/textAppearanceLarge" />

<TextView
    android:id="@+id/textView13"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignParentLeft="true"
    android:layout_below="@+id/textView14"
    android:layout_marginTop="30dp"
    android:text="textview 3"
    android:textAppearance="?android:attr/textAppearanceLarge" />

<EditText
    android:id="@+id/editText1"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignTop="@+id/textView14"
    android:layout_marginLeft="26dp"
    android:layout_toRightOf="@+id/textView14"
    android:ems="10" >

    <requestFocus />
</EditText>

<EditText
    android:id="@+id/editText2"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignBaseline="@+id/textView13"
    android:layout_alignBottom="@+id/textView13"
    android:layout_alignLeft="@+id/editText1"
    android:ems="10" />

<EditText
    android:id="@+id/editText3"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignLeft="@+id/editText2"
    android:layout_alignTop="@+id/textView12"
    android:ems="10" />

<EditText
    android:id="@+id/editText4"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignLeft="@+id/editText3"
    android:layout_centerVertical="true"
    android:ems="10" />

main1.xml

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
android:orientation="vertical">

<RelativeLayout
              android:layout_width="fill_parent"
              android:layout_height="wrap_content">

    <TextView android:layout_centerInParent="true"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:text="This is screen 2 called from activity scorecard."/>



</RelativeLayout>>

ScoreCard.java

package com.example.score.card;


public class ScoreCard extends Activity {

TextView textview1, textview2, textview3;
EditText editText1, editText2, editText3;
@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);
    onItemSelected();
}

private void onItemSelected() {
     textview1 = (TextView) findViewById(R.id.textView11);
     textview2 = (TextView) findViewById(R.id.textView12);
     textview3 = (TextView) findViewById(R.id.textView13);
     editText1 = (EditText) findViewById(R.id.editText1);
     editText2 = (EditText) findViewById(R.id.editText2);
     editText3 = (EditText) findViewById(R.id.editText3);
     setOnclickListener(textview1);
     setOnclickListener(textview2);
     setOnclickListener(textview3);     
}

private void setOnclickListener(final TextView textview12) {
    // TODO Auto-generated method stub
    textview12.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {
            // TODO Auto-generated method stub
            // Toast.makeText(getApplicationContext(),
            // textview12+" is selected", Toast.LENGTH_LONG).show();
            Intent intent = new Intent(getApplicationContext(), ScoreCard2.class);
            intent.putExtra("editText1", editText1.getText().toString());
            intent.putExtra("editText2", editText2.getText().toString());
            intent.putExtra("editText3", editText3.getText().toString());
            startActivity(intent);
        }
    });
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.main, menu);
    return true;
}
}

ScoreCard2.java

package com.example.score.card;


public class ScoreCard2 extends Activity{

@Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main1);
    onItemSelected();
}

 private void onItemSelected() {
        // TODO Auto-generated method stub          
         String strText1 = getIntent().getStringExtra("editText1");
         String strText2 = getIntent().getStringExtra("editText2");
         String strText3 = getIntent().getStringExtra("editText3");
         setOnclickListener(strText1);
         setOnclickListener(strText2);
         setOnclickListener(strText3);      
    }
private void setOnclickListener(String textview12) {
    // TODO Auto-generated method stub
     Toast.makeText(getApplicationContext(),
     textview12+" is selected", Toast.LENGTH_LONG).show();
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    // TODO Auto-generated method stub
    return super.onCreateOptionsMenu(menu);
}
}

AndroidManifest.xml

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.example.score.card"
android:versionCode="1"
android:versionName="1.0" >

<uses-sdk
    android:minSdkVersion="8"
    android:targetSdkVersion="15" />

<application
    android:icon="@drawable/ic_launcher"
    android:label="@string/app_name"
    android:theme="@style/AppTheme" >
    <activity
        android:name=".ScoreCard"
        android:label="@string/title_activity_score_card" >
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />

            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity>
      <activity android:name=".ScoreCard2"></activity>
</application>

Calling a method in another action from an action

More articles: