Geek asks and answers

Decorating recursive functions

I have a decorator that I wrote that there will be a time for a given function. It seems to work well with any function except recursive functions.

Decorator:

def tictoc(repeats=3, loops=1):
    def t(func):
        from functools import partial, wraps
        import timeit
        @wraps(func)
        def timer(*args, **kargs):
            elapsed = timeit.repeat(partial(func, *args, **kargs), repeat = repeats, number=loops)
            mine = min(elapsed)
            print "%s finished in %.5fs (%d loops, %d times) with %.5fs per loop" % (func.__name__, mine, loops, repeats, mine/loops)
        return timer
    return t

recursive function is the main Fibonacci algorithm.

@tictoc()
def fib(i):
    return ( 0 if i == 0 else
             1 if i == 1 else
             fib(i-1) + fib(i-2) )
fib(15)

The program crashes with the following error

fib finished in 0.00000s (1 loops, 3 times) with 0.00000s per loop
fib finished in 0.00000s (1 loops, 3 times) with 0.00000s per loop
fib finished in 0.00000s (1 loops, 3 times) with 0.00000s per loop
Traceback (most recent call last):
  File "decor.py", line 61, in <module>
    [fib(x) for x in range(1,50)]
  File "/home/grout/Dropbox/Python/tictoc.py", line 7, in timer
    elapsed = timeit.repeat(partial(func, *args, **kargs), repeat = repeats, number=loops)
  File "/usr/lib/python2.7/timeit.py", line 233, in repeat
    return Timer(stmt, setup, timer).repeat(repeat, number)
  File "/usr/lib/python2.7/timeit.py", line 221, in repeat
    t = self.timeit(number)
  File "/usr/lib/python2.7/timeit.py", line 194, in timeit
    timing = self.inner(it, self.timer)
  File "/usr/lib/python2.7/timeit.py", line 100, in inner
    _func()
  File "decor.py", line 59, in fib
    fib(i-1) + fib(i-2) )
TypeError: unsupported operand type(s) for +: 'NoneType' and 'NoneType'

I do not understand how the decorator executes several times and then fails. Any help would be appreciated.

+3
source share
2 answers

I think I'm going to settle this

def tictoc(func, repeats=3, loops=100, *args, **kargs):
    elapsed = timeit.repeat(lambda: func(*args, **kargs), repeat = repeats, number = loops)
    mine = min(elapsed)
    return "%s finished in %.5fs (%s loops, repeated %s times): %.5fs best time per loop"         %(func.__name__, mine, loops, repeats, mine/loops)
0
source

, , . , , fib , fib None. , fib, ( ), .

+6

More articles:


All Articles