Geek asks and answers

Android GridView Custom BaseAdapter ImageView ImageButton OnItemClick not working

I have a problem using a GridView with a CustomAdapter (extends BaseAdapter).

  • My activity implements OnItemClickListener.
  • If I use ImageView as an element, everything works fine, OnItemClick-Events will be fired / caught

I did not find a useful example for a GridView with a custom BaseAdapter using ImageButton. Anyone have an idea?

Snippets:

class MyActivity extends Activity implements OnItemClickListener {
  ...
  @Override
  public void onCreate() {
    ...
    GridView gridview = (GridView) findViewById(R.id.gridview);
    gridview.setOnItemClickListener(this);
    gridview.setAdapter(new ImageButtonAdapter(this));
  }
  ...    
  @Override
  public void onItemClick(AdapterView<?> adapter, View view, int arg2, long arg3)
  {
    Log.e("onItemClick()", "arg2=" + arg2 + ", arg3=" + arg3);
  }
}


public class ImageButtonAdapter extends BaseAdapter
{
  private Context    mContext;

  public LayoutMenuAdapter(Context c)
  {
    mContext = c;
  }

  public int getCount()
  {
    return mThumbIds.length;
  }

  public Object getItem(int position)
  {
    return null;
  }

  public long getItemId(int position)
  {
    return 0;
  }

  public View getView(int position, View convertView, ViewGroup parent)
  {

    /* IF I USE THIS PART EVERYTHING WORKS FINE */

    // ImageView imageView;
    // if (convertView == null) {
    //    imageView = new ImageView(mContext);
    //    imageView.setLayoutParams(new GridView.LayoutParams(100, 100));
    //    imageView.setScaleType(ImageView.ScaleType.CENTER_CROP);
    //    imageView.setPadding(0, 0, 0, 0);
    //    imageView.setFocusable(false);
    //  } else {
    //    imageView = (ImageView) convertView;
    //  }
    //  imageView.setImageResource(mThumbIds[position]);
    //  return imageView;

    /* IF I USE THIS PART NO THE ACTIVITY/LISTENER RECEIVES NO EVENT */

    ImageButton imageButton;
    if (convertView == null) {
      imageButton = new ImageButton(mContext);
      imageButton.setLayoutParams(new GridView.LayoutParams(100, 100));
      imageButton.setScaleType(ImageView.ScaleType.CENTER_CROP);
      imageButton.setPadding(0, 0, 0, 0);
      imageButton.setFocusable(false);
    } else {
      imageButton = (ImageButton) convertView;
    }
    imageButton.setImageResource(mThumbIds[position]);
    return imageButton;
  }

  // references to images
  private Integer[] mThumbIds = { R.drawable.media};
}
+3
source share
2 answers

Embed OnClickListener inside getView () .....

Class MyActivity extends Activity implements OnItemClickListener {
      ...
      @Override
      public void onCreate() {
        ...
        GridView gridview = (GridView) findViewById(R.id.gridview);
        gridview.setOnItemClickListener(this);
        gridview.setAdapter(new ImageButtonAdapter(this));
      }
      ...    
     // @Override
     // public void onItemClick(AdapterView<?> adapter, View view, int arg2, long arg3)
     // {
      //  Log.e("onItemClick()", "arg2=" + arg2 + ", arg3=" + arg3);
     // }
    }


    public class ImageButtonAdapter extends BaseAdapter
    {
      private Context    mContext;

      public LayoutMenuAdapter(Context c)
      {
        mContext = c;
      }

      public int getCount()
      {
        return mThumbIds.length;
      }

      public Object getItem(int position)
      {
        return null;
      }

      public long getItemId(int position)
      {
        return 0;
      }

      public View getView(int position, View convertView, ViewGroup parent)
      {

        /* IF I USE THIS PART EVERYTHING WORKS FINE */

        // ImageView imageView;
        // if (convertView == null) {
        //    imageView = new ImageView(mContext);
        //    imageView.setLayoutParams(new GridView.LayoutParams(100, 100));
        //    imageView.setScaleType(ImageView.ScaleType.CENTER_CROP);
        //    imageView.setPadding(0, 0, 0, 0);
        //    imageView.setFocusable(false);
        //  } else {
        //    imageView = (ImageView) convertView;
        //  }
        //  imageView.setImageResource(mThumbIds[position]);
        //  return imageView;

        /* IF I USE THIS PART NO THE ACTIVITY/LISTENER RECEIVES NO EVENT */

        ImageButton imageButton;
        if (convertView == null) {
          imageButton = new ImageButton(mContext);
          imageButton.setLayoutParams(new GridView.LayoutParams(100, 100));
          imageButton.setScaleType(ImageView.ScaleType.CENTER_CROP);
          imageButton.setPadding(0, 0, 0, 0);
          imageButton.setFocusable(false);
        } else {
          imageButton = (ImageButton) convertView;
        }
        imageButton.setImageResource(mThumbIds[position]);
        imageButton.setOnClickListener(new OnClickListener(){

             public void onClick(View arg0) {

                 Log.e("onClick()", position);

        }

         });
        return imageButton;
      }

      // references to images
      private Integer[] mThumbIds = { R.drawable.media};
    }
+1
source

Thank you very much for your help, now my activity is implemented only by OnClickListener, which will be transmitted to the adapter via ctor and attached to each button:

class MyActivity extends Activity implements OnClickListener {
  ...
  @Override
  public void onCreate() {
    ...
    GridView gridview = (GridView) findViewById(R.id.gridview);
    // gridview.setOnItemClickListener(this); // removed
    gridview.setAdapter(new ImageButtonAdapter(this, this));
  }
  ...    
  @Override
  public void onClick(View view)
  {
    Log.i("onClick()", "view=" + view);
  }
}


public class ImageButtonAdapter extends BaseAdapter
{
  private Context    mContext;

  private OnClickListener mListener;

  public LayoutMenuAdapter(Context c, OnClickListener l)
  {
    mContext = c;
    mListener = l;
  }

  public int getCount()
  {
    return mThumbIds.length;
  }

  public Object getItem(int position)
  {
    return null;
  }

  public long getItemId(int position)
  {
    return 0;
  }

  public View getView(int position, View convertView, ViewGroup parent)
  {
    ImageButton imageButton;
    if (convertView == null) {
      imageButton = new ImageButton(mContext);
      imageButton.setLayoutParams(new GridView.LayoutParams(100, 100));
      imageButton.setScaleType(ImageView.ScaleType.CENTER_CROP);
      imageButton.setPadding(0, 0, 0, 0);
      imageButton.setFocusable(false);
    } else {
      imageButton = (ImageButton) convertView;
    }
    imageButton.setImageResource(mThumbIds[position]);
    imageButton.setOnClickListener(mListener);
    return imageButton;
  }

  // references to images
  private Integer[] mThumbIds = { R.drawable.media};
}
+1
source

More articles:


All Articles