Geek asks and answers

IF condition optimization

  AddPatient = {};
  if(GenderValue === undefined) {
        AddPatient.Gender = ' ';  
    } else {
        AddPatient.Gender = GenderValue;  
    }
    if(DateOfBirthValue === undefined) {
        AddPatient.DateOfBirth = ' ';  
    } else {
        AddPatient.DateOfBirth = DateOfBirthValue;  
    }
    if(SSNValue === undefined) {
        AddPatient.SSN = ' ';  
    } else {
        AddPatient.SSN = SSNValue;  
    }
    if(RaceValue === undefined) {
        AddPatient.Race = ' ';  
    } else {
        AddPatient.Race = RaceValue;  
    }
    if(ReligionValue === undefined) {
        AddPatient.Religion = ' ';  
    } else {
        AddPatient.Religion = ReligionValue;  
    }
    if(CellPhoneValue === undefined) {
        AddPatient.CellPhoneNumber1 = ' ';  
    } else {
        AddPatient.CellPhoneNumber1 = CellPhoneValue;  
    }
    if(HomePhoneValue === undefined) {
        AddPatient.phonenumber1 = ' ';  
    } else {
        AddPatient.phonenumber1  = HomePhoneValue;  
    }
    if(PrimaryPhoneValue === undefined) {
        AddPatient.PrimaryPhoneNumber = ' ';  
    } else {
        AddPatient.PrimaryPhoneNumber = PrimaryPhoneValue;  
    }
    if(EmailValue === undefined) {
        AddPatient.EmailAddress1 = ' ';  
    } else {
        AddPatient.EmailAddress1 = EmailValue;  
    }
    AddPatient.ResidentialAddress = {};
    if(AddressValue === undefined) {
        AddPatient.AddressLine1 = ' ';  
    } else {
        AddPatient.ResidentialAddress.AddressLine1 = AddressValue;  
    }
    if(CityValue === undefined) {
        AddPatient.City = ' ';  
    } else {
        AddPatient.ResidentialAddress.City = CityValue;  
    }
    if(StateValue === undefined) {
        AddPatient.State = ' ';  
    } else {
        AddPatient.ResidentialAddress.State = StateValue;  
    }
    if(ZipValue === undefined) {
        AddPatient.PostalCode = ' ';  
    } else {
        AddPatient.ResidentialAddress.PostalCode = ZipValue;  
    }

Is there a better way to write the same code?

+3
source share
4 answers

You can write

AddPatient.Gender = GenderValue || " ";

The operator ||returns the "true" to the left operand, so it will be assessed before " ", if GenderValuea "false" (such as undefined, false, "", 0or null)

+15
source

Here is a suggestion for what you actually asked:

http://jsfiddle.net/mplungjan/b5yRw/

Of course, he will work with the form.

var GenderValue = "F";
var DateOfBirthValue; // undefined
var AddressValue = "some street";   
// var CityValue;  // undeclared


function addItem(obj,varName) {
  obj[varName] = window.hasOwnProperty(varName+"Value")?window[varName+"Value"]||"not set":"not declared";
}

function addItemLoop(obj) {
  for (var o in obj) {
    if (typeof obj[o] === 'object') {
      addItemLoop(obj[o]);
    }
    else {
      addItem(obj, o);
    }
  }
}

AddPatient = {
  Gender : " ",
  DateOfBirth: " ",
  ResidentialAddress : {
    Address:" ",
    City: " "
  }
}
addItemLoop(AddPatient);

document.write("<br/>Gender (F):"+AddPatient.Gender);
document.write("<br/>DOB (not set):"+AddPatient.DateOfBirth);
document.write("<br/>ResidentialAddress Address (some street):"+AddPatient.ResidentialAddress.Address);
document.write("<br/>ResidentialAddress City (not declared):"+AddPatient.ResidentialAddress.City);

Previous answer

Not better, but shorter using the ternary operator

AddPatient.Gender = (GenderValue === undefined)? " ":GenderValue;

or shortcut

AddPatient.Gender = GenderValue || " ";

Note. In the shortcut you will get a space if the value is 0

, GenderValue . - var GenderValue;

:

var b="hello", c;
var a = {}
a.x = b||"no b"
a.y = (c===undefined)? "no c here":c
a.z = c || "no c here either" 
alert(a.x)
alert(a.y)
alert(a.z)
+1
 function isDefined(value){
     if(value != null)
       return value;
     else
      return ' ';
   }

    AddPatient = {};


AddPatient.Gender =isDefined(AddPatient);

+1
source

Here is one of the options:

function SetOrDefault(value, property) {
  if (typeof(value) == 'undefined' || value == null) {
    property = ' ';
  }
  else {
    property = value;
  }
}

And then name it like this:

SetOrDefault(GenderValue, AddPatient.Gender);
0
source

More articles:


All Articles