Segmentation error in C ++ stream

I am trying to create a base class with threads in C ++, but I get a seg error when I try to create a stream. Here is what GDB reports:

Program received signal SIGSEGV, Segmentation fault.
0x0000000000401b68 in StartThread (pFunction=
    0x401ad2 <FindPrimesThread(void*)>, pLimit=5000000) at Thread.cpp:35
35          state->mLimit = pLimit;

when I try to call it like this:

ThreadState *primesState = StartThread(FindPrimesThread, 5000000);

Here is my code:

Thread.hpp

#ifndef THREAD_HPP
#define THREAD_HPP

#include <pthread.h>
#include "Types.hpp"

typedef struct {
    ulong       mLimit;     // Upper limit of numbers to test 
    int         mStarted;   // True if the thread started successfully
    int         mExitCode;  // Thread exit code
    pthread_t   mThreadId;  // Thread ID
} ThreadState;

// Defines a type named ThreadFunction which is a pointer to a function with void * as the parameter and
// void * as the return value.
typedef void *(*ThreadFunction)(void *);

ThreadState *StartThread
    (
    ThreadFunction const pFunction,  // Pointer to the thread function
    ulong const          pLimit      // Upper limit of numbers to test
    );

#endif

Thread.cpp

#include "Amicable.hpp"
#include "Keith.hpp"
#include "Main.hpp"
#include "Prime.hpp"
#include "Thread.hpp"

ThreadState *StartThread
    (
    ThreadFunction const pFunction,  // Pointer to the thread function
    ulong const          pLimit      // Upper limit of numbers to test
    ) {
        ThreadState *state;
        state->mLimit = pLimit;
        pthread_t threadId;
        state->mStarted = pthread_create(&threadId, NULL, pFunction, (void *)state);
        if(state->mStarted == 0){
            state->mThreadId = threadId;
        }
        return state;
    }

Any idea what is going wrong here?

+3
source share
2 answers
ThreadState *state;
state->mLimit = pLimit;

You write to a memory that you did not allocate

+7
source

You have an uninitialized pointer in a ThreadState. On line 35, you create a pointer to a ThreadState, but you never assign this pointer to any ThreadState.

, - . "ThreadState *" , " , , ThreadState".

, "ThreadState * state = new ThreadState();"? , - ThreadState, , !

+3

All Articles