Geek asks and answers

Exception-based form validation

I use sentry as an auth package for my application, this is my controller method for registering users.

class Controller_Auth extends \Controller_Base
{

    function action_signup($type='user')
    {
        $user = \Fieldset::forge('new_user');
        $user->add('email', 'Email', array(), array(array('required'), array('valid_email')));
        $user->add('password', 'Password', array(), array(array('required')));
        $user->add('confirm_password', 'Confirm Password', array(), array(array('match_field', 'password') ));
        $user->add('submit', '', array('value'=>'Sign Up', 'class' => 'btn', 'type'=>'submit'));

        $user->repopulate();

        if($user->validation()->run())
        {

            try
            {
                $fields = $user->validated();

                $user_id = \Sentry::user()->create(array('email'=>$fields['email'], 'password'=>$fields['password']));

                if($user_id)
                {
                    // the user was created - send email notifying user account was created
                }
                else
                {
                    // something went wrong - shouldn't really happen
                }
            }
            catch(\SentryUserException $e)
            {
                \Library_Message::set('error', $e->getMessage());
            }
            catch(\Database_Exception $e)
            {
                \Library_Message::set('error', 'Database error occured. Please try again');
            }
        }
        else
        {
            \Library_Message::set('error', $user->validation()->errors());
        }

        $this->template->set('content', $user->form(), false);
    }

}

As you can see, I am mixing both validation errors and exceptions, I was wondering if there is a way to handle all errors using exceptions?

+3
source share
1 answer

I suggest creating a private method that throws an exception for errors to make this uniform.

/**
 *
 * @throws Exception
 */
private function validateUserRun($user) {
   if(!$user->validation()->run()) {
       throw new YourException(); //Use a different exception than 'Exception' please
   }
}

And then name it on the try block

function action_signup($type='user') { 
//...
   try {
     $this->validateUserRun($user);
     $fields = $user->validated();
     //...
   } 
   catch(\SentryUserException $e) {
            \Library_Message::set('error', $e->getMessage());
   } catch(\Database_Exception $e) {
            \Library_Message::set('error', 'Database error occured. Please try again');
   } catch (YourException $e) {
      //Here you can catch the exception
   }
//...
}
0
source

More articles:


All Articles