Geek asks and answers

Alternative if else when using paired

Based on salaries, I need to assign a certain tax rate on the objects of my employee. The salary is determined by yearlySalary, which is double, so I could not use the switch statement. Instead, I used if / else:

public int getSalaryRank() {
    if(yearlySalary <= 60000.00) {
        salaryRank = 1;
    } else if(yearlySalary > 60000.00 && yearlySalary <= 80000.00) {
        salaryRank = 2;
    } else if(yearlySalary > 80000.00 && yearlySalary <= 100000.00) {
        salaryRank = 3;
    } else if(yearlySalary > 100000.00 && yearlySalary <= 125000.00) {
        salaryRank = 4;
    } else {
        salaryRank = 5;
    } return salaryRank; }

I will set tax rates later depending on the rank. Is there a better way to write this?

+3
source share
4 answers

You can simplify it as follows:

public int getSalaryRank() {
    int salaryRank;

    if(yearlySalary <= 60000.00) {
        return  1;
    } 

    if(yearlySalary <= 80000.00) {
        return 2;
    } 

    if(yearlySalary <= 100000.00) {
        return 3;
    } 

    if(yearlySalary <= 125000.00) {
       return 4;
    } 

    return 5

}

, . , else salaryrank. , , . BigDecimal

: @AlexWien , :

public int getSalaryRank() {
        if(yearlySalary <= 60000.00) {
            salaryRank = 1;
        } else  if(yearlySalary <= 80000.00) {
            salaryRank = 2;
        } else if(yearlySalary <= 100000.00) {
            salaryRank = 3;
        } else if(yearlySalary <= 125000.00) {
           salaryRank = 4;
        } else {
           salaryRank = 5;
        }  

        return salaryRank;

    }
+3

while ().

+4

:

public int getSalaryRank() 
{
    if(yearlySalary <= 60000.00) return 1;
    if(yearlySalary <= 80000.00) return 2;
    if(yearlySalary <= 100000.00) return 3;
    if(yearlySalary <= 125000.00) return 4;
    return 5;
}
+2

else, if . , : yearlySalary > 60000.00 &&

if(yearlySalary <= 60000.00) {
    salaryRank = 1;
} else if(yearlySalary <= 80000.00) {
    salaryRank = 2;
}

, . , , , , 0.1. . BigDecimal - .

+2

More articles:


All Articles